-
Notifications
You must be signed in to change notification settings - Fork 5.2k
deps: Bump rules_rust to 0.67.0 #42194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
34e4338 to
2f78fc7
Compare
|
im almost certain this wont work without enabling cc_toolchain_resolution |
7b25910 to
41293b0
Compare
4b4599d to
cb828d1
Compare
|
/retest |
aa52124 to
48b45f9
Compare
c875e9f to
be3732a
Compare
|
/retest |
ec58d4b to
5ec4ceb
Compare
|
/retest |
|
@mmorel-35 looks like you have cc_toolchain_resolution working - nice work! im wondering if its possible to separate out that change from the rules_rust update - its the more significant change and has implications for downstream builders so would be better to land separately (or at least i think we need to change the commit title) |
I created #42201 |
d957572 to
f879520
Compare
f879520 to
3905278
Compare
3905278 to
b19b52e
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
b19b52e to
ffdbca0
Compare
phlax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @mmorel-35
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
Fixes #41678
[Optional Fixes commit #PR or SHA]
Fixes #41630 Fixes #41172
[Optional Deprecated:]
[Optional API Considerations:]