Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 22, 2025

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
Fixes #41678
[Optional Fixes commit #PR or SHA]
Fixes #41630 Fixes #41172
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #42194 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 22, 2025
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @agrawroh

🐱

Caused by: #42194 was opened by mmorel-35.

see: more, trace.

@phlax
Copy link
Member

phlax commented Nov 22, 2025

im almost certain this wont work without enabling cc_toolchain_resolution

@mmorel-35 mmorel-35 force-pushed the rules_rust@0.67.0 branch 2 times, most recently from 4b4599d to cb828d1 Compare November 22, 2025 21:42
@mmorel-35 mmorel-35 marked this pull request as ready for review November 22, 2025 22:02
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 force-pushed the rules_rust@0.67.0 branch 2 times, most recently from c875e9f to be3732a Compare November 23, 2025 07:03
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 force-pushed the rules_rust@0.67.0 branch 2 times, most recently from ec58d4b to 5ec4ceb Compare November 23, 2025 09:07
@mmorel-35
Copy link
Contributor Author

/retest

@phlax
Copy link
Member

phlax commented Nov 23, 2025

@mmorel-35 looks like you have cc_toolchain_resolution working - nice work!

im wondering if its possible to separate out that change from the rules_rust update - its the more significant change and has implications for downstream builders so would be better to land separately (or at least i think we need to change the commit title)

@mmorel-35
Copy link
Contributor Author

im wondering if its possible to separate out that change from the rules_rust update - its the more significant change and has implications for downstream builders so would be better to land separately (or at least i think we need to change the commit title)

I created #42201

@mmorel-35 mmorel-35 force-pushed the rules_rust@0.67.0 branch 2 times, most recently from d957572 to f879520 Compare November 23, 2025 10:05
@mmorel-35
Copy link
Contributor Author

Needs #42194 and #42198

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mmorel-35

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 23, 2025
@phlax phlax enabled auto-merge (squash) November 23, 2025 10:44
@phlax phlax merged commit ef11621 into envoyproxy:main Nov 23, 2025
25 checks passed
@mmorel-35 mmorel-35 deleted the rules_rust@0.67.0 branch November 23, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newer release available rules_rust: 0.67.0 (current: 0.56.0)

3 participants