[ProtoApiScrubber] Add UTs for array type in FieldChecker #42191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumit Kumar <sumitkmr@google.com>
Signed-off-by: Sumit Kumar <sumitkmr@google.com>
adisuissa
approved these changes
Nov 24, 2025
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
LGTM thanks.
I've left a couple of style comments that can be addressed in a followup PR.
| addRestriction(config, method, "metadata.history.edits", FieldType::Request, true); | ||
|
|
||
| // Repeated Message: "chapters" -> No Rule (Should result in Partial to scrub children) | ||
|
|
Contributor
There was a problem hiding this comment.
nit: remove unnecessary empty lines.
| ProtoApiScrubberConfig config; | ||
| std::string method = "/library.BookService/UpdateBook"; | ||
|
|
||
| // Top-level repeated primitive: "tags" -> Remove |
Contributor
There was a problem hiding this comment.
style-nit: comments start with a capital letter and end with '.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add UTs for array type in FieldChecker.
Additional Description: This is the first part of support for non-primitive types. Enums, maps and
Anytype will follow. For arrays, there's no additional change needed in theCheckField()method. The field paths for array's child fields would be configured just like simple message's child fields and theproto_scrubberlibrary also passes thepathargument toCheckFieldjust like simple message. ProtoApiScrubber would not support index level scrubbing i.e., the scrubbing rules in the filter config can't be defined array index wise. e.g., for a fieldrequest.api_keys_list[*].current_keywould be configured asrequest.api_keys_list.current_key.Risk Level: None
Testing: UTs are added.
Docs Changes: None for now. The documentation (once published) will contain guidelines for configuring array types.
Release Notes: None.
Platform Specific Features: None.
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]