fips: Fix build errors #39565
Merged
fips: Fix build errors #39565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawroh
previously approved these changes
May 21, 2025
phlax
commented
May 21, 2025
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -evxo pipefail | |||
| set -eo pipefail | |||
There was a problem hiding this comment.
this is the actual fix - the rest was cleanup/debugging as i was confused how it was erroring without failing
this is what it fixes
Signed-off-by: Ryan Northey <ryan@synca.io>
ggreenway
approved these changes
May 21, 2025
fishpan1209
pushed a commit
to fishpan1209/envoy
that referenced
this pull request
May 22, 2025
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Ting Pan <panting@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.