core: unify uint32_t in connection pool clients and max_request_per_connection #39275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
botengyao
requested review from
zuercher,
yanavlasov and
mattklein123
as code owners
|
/assign-from @envoyproxy/envoy-maintainers |
|
@envoyproxy/envoy-maintainers assignee is @jmarantz |
Signed-off-by: Boteng Yao <boteng@google.com>
jmarantz
reviewed
Apr 30, 2025
| ActiveClient(HttpConnPoolImplBase& parent, uint64_t lifetime_stream_limit, | ||
| uint64_t effective_concurrent_stream_limit, | ||
| uint64_t configured_concurrent_stream_limit, | ||
| ActiveClient(HttpConnPoolImplBase& parent, uint32_t lifetime_stream_limit, |
There was a problem hiding this comment.
What does 'lifetime' mean here? I'm just wondering if we are counting a potentially huge number of events over the lifetime of a server.
There was a problem hiding this comment.
It is the upstream's connection's life time to the backends, and it could be large, but it is not the lifetime of a server.
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
ggreenway
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_requests_per_connectionisuint32Valuein the http options and cluster configs, so no need to useuint64_tuint64_tfor any limits and the baseEnvoy::ConnectionPool::ActiveClientare alluint32_t.Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features: