lua: filter context implementation #39263
Conversation
Signed-off-by: wangbaiping(wbpcode) <wbphub@gmail.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
| } | ||
|
|
||
| const ProtobufWkt::Struct& filterContext() const { | ||
| return per_route_config_ == nullptr ? ProtobufWkt::Struct::default_instance() |
There was a problem hiding this comment.
perf-nit: seems a bit wasteful to always pass the default_instance in cases where the filter_context field wasn't set.
I'm not sure what are the performance implications, and that's why I'd leave it up to the code-owners (you) to decide.
There was a problem hiding this comment.
The ProtobufWkt::Struct::default_instance() will return a const refrerence to a global variable. Basically, it won't bring any performance penality.
There was a problem hiding this comment.
I will defer this to @ggreenway. @ggreenway is familiar to Lua code.
There was a problem hiding this comment.
The ProtobufWkt::Struct::default_instance() will return a const refrerence to a global variable. Basically, it won't bring any performance penality.
I was refering to the call to luaFilterContext that I don't understand when it will to be invoked.
If you think that's ok, or that the overhead will be minimal, SGTM.
Commit Message: lua: filter context implementation
Additional Description:
Risk Level: low.
Testing: unit.
Docs Changes: added.
Release Notes: added.
Platform Specific Features: n/a.