Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: protects client against stream not found #36573

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

birenroy
Copy link
Contributor

@birenroy birenroy commented Oct 14, 2024

There are similar checks already on the server side:

if (stream_ptr != nullptr) {

Commit Message: http2: protects client against stream not found
Additional Description:
Risk Level: low
Testing: ran unit and integration tests locally
Docs Changes:
Release Notes:
Platform Specific Features:

Signed-off-by: Biren Roy <birenroy@google.com>
Signed-off-by: Biren Roy <birenroy@google.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #36573 was opened by birenroy.

see: more, trace.

@birenroy birenroy marked this pull request as ready for review October 14, 2024 16:10
@birenroy
Copy link
Contributor Author

/assign @alyssawilk
/assign @RyanTheOptimist

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you had trouble e2e testing but I suspect you could unit test this
/wait-any

Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a unit test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants