apple_dns: Update the Apple DNS resolution details #36536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredy Wijaya <fredyw@google.com>
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Fredy Wijaya <fredyw@google.com>
|
/assign @alyssawilk |
alyssawilk
reviewed
Oct 14, 2024
| @@ -378,6 +378,8 @@ void AppleDnsResolverImpl::PendingResolution::onDNSServiceGetAddrInfoReply( | |||
| if (!(flags & kDNSServiceFlagsMoreComing) && isAddressFamilyProcessed(kDNSServiceProtocol_IPv4) && | |||
| isAddressFamilyProcessed(kDNSServiceProtocol_IPv6)) { | |||
| ENVOY_LOG(debug, "DNS Resolver flushing queries pending callback"); | |||
| pending_response_.status_ = ResolutionStatus::Completed; | |||
| pending_response_.details_ = "apple_dns_success"; | |||
There was a problem hiding this comment.
was this broken before? Can we regression test?
/wait
There was a problem hiding this comment.
We discovered some instances of not_set in our testing, which gives the impression that the DNS query never gets executed. This is because by default, the status is set to Completed and details to not_set. This PR aims to fix the potential confusion.
I also updated the PR to add missing tests for the DNS resolution details that previously didn't exist.
Signed-off-by: Fredy Wijaya <fredyw@google.com>
fredyw
changed the title
fredyw
changed the title
|
/retest |
alyssawilk
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the DNS resolution details from
apple_dns_successtoapple_dns_immediate_successfor an immediate success and fromnot_settoapple_dns_successfor a successful case. This PR also adds missing test cases for the Apple DNS resolution details.Risk Level: low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: apple_dns