Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump proxy_wasm_rust_sdk -> 0.2.2 #35323

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

dependency-envoy[bot]
Copy link
Contributor

@dependency-envoy dependency-envoy bot commented Jul 22, 2024

Created by Envoy dependency bot for @phlax

Fix #35321

also update rules_rust -> 0.48.0

Fix #35291

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jul 22, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #35323 was opened by dependency-envoy[bot].

see: more, trace.

@phlax
Copy link
Member

phlax commented Jul 22, 2024

cc @mpwarres @martijneken updating these deps is still blocked by proxy-wasm-cpp-host needing an update (and conversion to crate_universe etc)

@soulxu
Copy link
Member

soulxu commented Jul 29, 2024

/wait

@phlax is it still blocked?

@phlax
Copy link
Member

phlax commented Jul 29, 2024

is it still blocked?

yeah, i believe so

@phlax phlax changed the title deps: Bump proxy_wasm_rust_sdk -> 0.2.2 [WIP] deps: Bump proxy_wasm_rust_sdk -> 0.2.2 Jul 29, 2024
@phlax phlax marked this pull request as draft July 29, 2024 10:08
@martijneken
Copy link

Hi. I'm working on the crate_universe issue, I think that's close to being fixed. @mpwarres is back from OOO this week and will be looking at the macOS issue.

Can you clarify which parts are blocking the rust SDK, and whether these CI issues will actually unblock you? I don't know how they are related.

@phlax
Copy link
Member

phlax commented Jul 29, 2024

so this is the error

ERROR: /build/bazel_root/base/external/proxy_wasm_cpp_host/bazel/cargo/wasmtime/BUILD.bazel:42:6: error loading package '@wasmtime__wasmtime__9_0_3//': cannot load '@rules_rust//cargo:cargo_build_script.bzl': no such file and referenced by '@proxy_wasm_cpp_host//bazel/cargo/wasmtime:wasmtime'
ERROR: Evaluation of query "deps((//contrib/exe/... union //distribution/... union //source/exe/... union @com_github_google_quiche//:ci_tests union @nodejs//... union //test/...))" failed: preloading transitive closure failed: error loading package '@wasmtime__wasmtime__9_0_3//': cannot load '@rules_rust//cargo:cargo_build_script.bzl': no such file
Fetch failed

i went down the rabbit hole a little last week and came to the conclusion that we needed to update rules_rust to update proxy_wasm_rust_sdk - i tried to do that here (in this PR) and hit above issue

i looked at the changes in the rules_rust repo and (cant rem exactly why) came to the conclusion we need to update cpp-host first

@martijneken
Copy link

needed to update rules_rust to update proxy_wasm_rust_sdk

Ahh gotcha, I'll look at that in CppHost too then.

@martijneken
Copy link

CppHost CI is fixed, rules_rust to be updated in proxy-wasm/proxy-wasm-cpp-host#406.

@phlax
Copy link
Member

phlax commented Aug 13, 2024

brilliant, thanks @martijneken - ill have a go again at bumping this batch of deps

@phlax phlax force-pushed the dependency/bazel/proxy_wasm_rust_sdk/0.2.2 branch from 3cc00ba to f7a6949 Compare August 27, 2024 13:07
@phlax
Copy link
Member

phlax commented Aug 27, 2024

@martijneken
Copy link

martijneken commented Aug 28, 2024

unfortunately this still fails due to bazelbuild/rules_rust#2665

Seems like we ran into this on the ProxyWasmCppHost side too, and decided to use rules_rust 0.42 for now:
https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/f199214a43337e115469d9f0dd6b77858746441b/bazel/repositories.bzl#L93-L103

Can we do the same here?

@phlax
Copy link
Member

phlax commented Aug 29, 2024

Can we do the same here?

most likely, ill try it now ...

dependency-envoy bot and others added 4 commits August 29, 2024 12:44
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the dependency/bazel/proxy_wasm_rust_sdk/0.2.2 branch from 90c4e42 to 818d045 Compare August 29, 2024 11:45
@phlax
Copy link
Member

phlax commented Aug 29, 2024

seems not out of the box - afaict its failing due to:

https://github.com/proxy-wasm/proxy-wasm-rust-sdk/blob/3f4274ec8c6276cb187eb2c3a76752cb915b9c01/bazel/cargo/remote/BUILD.ahash-0.8.11.bazel#L208

which i think is most likely related to the rules_rust version which is higher in rust-sdk

@krinkinmu
Copy link

unfortunately this still fails due to bazelbuild/rules_rust#2665

Seems like we ran into this on the ProxyWasmCppHost side too, and decided to use rules_rust 0.42 for now: https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/f199214a43337e115469d9f0dd6b77858746441b/bazel/repositories.bzl#L93-L103

Can we do the same here?

Hi @phlax and @martijneken ,

just a drive-by comment. I was working on a personal project and was able to update rules_rust in envoy to the latest version that has pkg_name attribute already. To work around the issue in bazelbuild/rules_rust#2665 I added this to the .bazelrc:

build --incompatible_merge_fixed_and_default_shell_env

Patching rules_rust also worked, but just setting incompatible_merge_fixed_and_default_shell_env to the value that became default in later bazel versions seemed like a better approach.

Maybe you can give that a try?

@phlax
Copy link
Member

phlax commented Sep 18, 2024

brilliant! huge thanks @krinkinmu - ill give it a whirl

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the dependency/bazel/proxy_wasm_rust_sdk/0.2.2 branch from 0b95468 to fc24e00 Compare September 18, 2024 12:17
@phlax phlax changed the title [WIP] deps: Bump proxy_wasm_rust_sdk -> 0.2.2 deps: Bump proxy_wasm_rust_sdk -> 0.2.2 Sep 18, 2024
@phlax phlax marked this pull request as ready for review September 18, 2024 12:34
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, looks like this is finally passing

thanks all!

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 18, 2024
@phlax phlax enabled auto-merge (squash) September 18, 2024 13:13
@phlax phlax merged commit 7fb927d into main Sep 18, 2024
39 of 40 checks passed
@phlax phlax deleted the dependency/bazel/proxy_wasm_rust_sdk/0.2.2 branch September 20, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants