-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GrpcFieldExtraction: Supports extracting fields of type map<string, string>
in addition to string
#35162
Conversation
Hi @sissisuna, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please add a release note, thanks.
/wait
@mattklein123 Thanks for reviewing the change! The release notes are already part of the description as "Release Notes: This change is backward compatible and no behavior change is expected for existing users.", can you please let me know if anything else is missing or if I need to add it to an additional place? |
…string>` in addition to string. Risk Level: Low Testing: Unit tests Docs Changes: Inline with the filter API proto. Release Notes: This change is backward compatible and no behavior change is expected for existing users. Signed-off-by: Xi Wu <xiwuxw@google.com>
/retest |
2 similar comments
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a release note here: https://github.com/envoyproxy/envoy/blob/main/changelogs/current.yaml
Please look at other changes and the contributing guide to learn more.
/wait
Signed-off-by: Xi Wu <xiwuxw@google.com>
/retest |
Signed-off-by: Xi Wu <xiwuxw@google.com>
/retest |
1 similar comment
/retest |
/retest |
/retest |
Sorry please merge main. /wait |
Signed-off-by: Xi Wu <xiwuxw@google.com>
Head branch was pushed to by a user without write access
…string>` in addition to string (envoyproxy#35162) Commit Message: GrpcFieldExtraction: Supports extracting fields of type `map<string, string>` in addition to string Additional Description: Risk Level: Low Testing: Unit test Docs Changes: Inline with the filter API proto. Release Notes: This change is backward compatible and no behavior change is expected for existing users. Platform Specific Features: --------- Signed-off-by: Xi Wu <xiwuxw@google.com> Signed-off-by: asingh-g <abhisinghx@google.com>
<!-- !!!ATTENTION!!! If you are fixing *any* crash or *any* potential security issue, *do not* open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure. !!!ATTENTION!!! For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md) --> ProtobufWkt::Value is introduced by #35162 Commit Message: Additional Description: Risk Level: low Testing: Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: Boteng Yao <boteng@google.com>
Commit Message: GrpcFieldExtraction: Supports extracting fields of type
map<string, string>
in addition to stringAdditional Description:
Risk Level: Low
Testing: Unit test
Docs Changes: Inline with the filter API proto.
Release Notes: This change is backward compatible and no behavior change is expected for existing users.
Platform Specific Features: