Fix for SSL Client Auth filter closing connection without reason #35034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arul Thileeban Sagayam <arul.thilee@gmail.com>
ggreenway
requested changes
Jul 3, 2024
| @@ -167,7 +167,7 @@ TEST_F(ClientSslAuthFilterTest, Ssl) { | |||
| setResponseFlag(StreamInfo::CoreResponseFlag::UpstreamProtocolError)); | |||
| EXPECT_CALL(filter_callbacks_.connection_.stream_info_, | |||
| setResponseCodeDetails("auth_digest_no_match")); | |||
| EXPECT_CALL(filter_callbacks_.connection_, close(Network::ConnectionCloseType::NoFlush)); | |||
| EXPECT_CALL(filter_callbacks_.connection_, close(Network::ConnectionCloseType::NoFlush, _)); | |||
There was a problem hiding this comment.
Please validate that the reason is "auth_digest_no_match"
There was a problem hiding this comment.
Thanks. Added it
Signed-off-by: Arul Thileeban Sagayam <arul.thilee@gmail.com>
ggreenway
approved these changes
Jul 3, 2024
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…voyproxy#35034) Fixes envoyproxy#34997 Signed-off-by: Arul Thileeban Sagayam <arul.thilee@gmail.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…voyproxy#35034) Fixes envoyproxy#34997 Signed-off-by: Arul Thileeban Sagayam <arul.thilee@gmail.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…voyproxy#35034) Fixes envoyproxy#34997 Signed-off-by: Arul Thileeban Sagayam <arul.thilee@gmail.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…voyproxy#35034) Fixes envoyproxy#34997 Signed-off-by: Arul Thileeban Sagayam <arul.thilee@gmail.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Fix for SSL Client Auth filter closing connection without reason
Risk Level: Low
Testing: Unit testing
Docs Changes: N/A
Release Notes: N/A
Fixes #34997