docs: clarify Windows build status #34328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/34328/docs/index.html The docs are (re-)rendered each time the CI |
phlax
reviewed
May 24, 2024
| @@ -33,7 +33,9 @@ as the new tcmalloc code is not guaranteed to compile with lower versions of Cla | |||
| Windows Target Requirements | |||
There was a problem hiding this comment.
i wonder whether we should remove this section given we cant guarantee that it will build
There was a problem hiding this comment.
We need to keep is somewhere for the record, in case someone wants to come in and resurrect Windows build. With the note I think the expectations of Windows build state are clear.
|
/backport |
repokitteh-read-only
bot
added
the
backport/review
yanavlasov
reviewed
May 24, 2024
There was a problem hiding this comment.
LGTM from me. Will wait for @phlax review before committing.
/wait-any
phlax
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #28588, Windows builds are unsupported. Make that clear in the documentation.
Additionally, remove references to the Windows docker image, which has not been updated
since 1.28.0 with the intention of not directing Windows operators towards a version missing
important security updates.
Risk Level: low, docs only
Testing: n/a
Docs Changes: yes
Release Notes: n/a
Platform Specific Features: n/a