-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify Windows build status #34328
Conversation
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/34328/docs/index.html The docs are (re-)rendered each time the CI |
@@ -33,7 +33,9 @@ as the new tcmalloc code is not guaranteed to compile with lower versions of Cla | |||
Windows Target Requirements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder whether we should remove this section given we cant guarantee that it will build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep is somewhere for the record, in case someone wants to come in and resurrect Windows build. With the note I think the expectations of Windows build state are clear.
/backport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me. Will wait for @phlax review before committing.
/wait-any
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @zuercher
Per #28588, Windows builds are unsupported. Make that clear in the documentation.
Additionally, remove references to the Windows docker image, which has not been updated
since 1.28.0 with the intention of not directing Windows operators towards a version missing
important security updates.
Risk Level: low, docs only
Testing: n/a
Docs Changes: yes
Release Notes: n/a
Platform Specific Features: n/a