Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify in the docs matching by wildcard of the sni_domains field in listener components #3371

Conversation

vadimeisenbergibm
Copy link
Contributor

title: sni_domains: clarify in the documentation matching by a wildcard

Description:
According to

const size_t pos = server_name.find('.');

the wildcard is allowed before the first dot, it means that www.example.com will be matched by an SNI domain *.example.com, but not by *.com or *. The proposed PR changes the docs to explain it.

Risk Level: Low

Testing:
Documentation change, no testing.

Docs Changes:
The PR is a docs change only.

Release Notes:
None.

Fixes #3363 .

@vadimeisenbergibm
Copy link
Contributor Author

Closing it since the commits were not signed, my first PR to Envoy, sorry. Resubmitted with a signed commit #3372.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant