-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update the deprecation status of libcurl #30731
Conversation
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
To fully understand the timeline, are we basically saying that when |
Yes, with removing |
OK, can you be explicit on this timeline in the Bazel comments? E.g. link to your above GH post. |
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
Thanks @htuch for the help. Please let me know if the code comments is sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Commit Message: deps: update the deprecation status of libcurl
Additional Description:
Following the merge of #29880 and #30626 we can mark the curl usage as deprecated. Meanwhile bazel/repositories.bzl had stale info that OpenCensus tracer was still using libcurl.
We can continue to keep the Issue #11816 open until curl is removed entirely after the deprecation time (Probably for v1.31 release).
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]