Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update the deprecation status of libcurl #30731

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

suniltheta
Copy link
Contributor

Commit Message: deps: update the deprecation status of libcurl
Additional Description:
Following the merge of #29880 and #30626 we can mark the curl usage as deprecated. Meanwhile bazel/repositories.bzl had stale info that OpenCensus tracer was still using libcurl.

We can continue to keep the Issue #11816 open until curl is removed entirely after the deprecation time (Probably for v1.31 release).

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 5, 2023
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #30731 was opened by suniltheta.

see: more, trace.

@htuch
Copy link
Member

htuch commented Nov 5, 2023

To fully understand the timeline, are we basically saying that when envoy.reloadable_features.use_libcurl_to_fetch_aws_credentials is removed, we'll remove the libcurl dep?

@suniltheta
Copy link
Contributor Author

Yes, with removing envoy.reloadable_features.use_libcurl_to_fetch_aws_credentials we should remember to remove curl dependency and any other artifacts related to curl within Envoy. Now that the reloadable feature is going to be released with v1.29, hopefully before 1.31 we can get rid of the feature flag.

@htuch
Copy link
Member

htuch commented Nov 5, 2023

OK, can you be explicit on this timeline in the Bazel comments? E.g. link to your above GH post.

Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
@suniltheta
Copy link
Contributor Author

Thanks @htuch for the help. Please let me know if the code comments is sufficient.

Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Nov 7, 2023
@htuch htuch merged commit dd05ef6 into envoyproxy:main Nov 7, 2023
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants