-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing: Deprecate Opencensus (@1.30) #29063
Conversation
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
cc @kyessenov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per offline discussions.
dc4c9b2
to
e33ce96
Compare
dd7bd19
to
60dbc3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy we're first deprecating with a notice. Personally I feel the OpenCensus project has been archived too early as OpenTelemetry has not been great at getting to production readiness (especially metrics in Go). But I do believe their decision has made it inevitable for us to get rid of non maintained code with some sense of urgency. This strikes a good balance for people needing to switch over.
Signed-off-by: Ryan Northey <ryan@synca.io>
60dbc3f
to
1e739f0
Compare
@@ -48,29 +48,35 @@ message OpenCensusConfig { | |||
reserved 7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@htuch you may know why - the one thing i didnt manage to do was deprecate the enum above (in file)
not sure why - probs i was just doing it wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably only matters that you deprecate the fields that reference it.
related to #9958
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]