Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: Deprecate Opencensus (@1.30) #29063

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Aug 16, 2023

related to #9958

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #29063 was opened by phlax.

see: more, trace.

@phlax phlax assigned yanavlasov and unassigned markdroth Aug 16, 2023
@phlax
Copy link
Member Author

phlax commented Aug 16, 2023

cc @kyessenov

kyessenov
kyessenov previously approved these changes Aug 16, 2023
Copy link
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per offline discussions.

@phlax phlax changed the title tracing: Deprecate Opencensus (@2.10) [WIP] tracing: Deprecate Opencensus (@2.10) Aug 16, 2023
@phlax phlax force-pushed the deprecate-opencensus branch 2 times, most recently from dd7bd19 to 60dbc3f Compare August 16, 2023 17:57
@phlax phlax changed the title [WIP] tracing: Deprecate Opencensus (@2.10) [WIP] tracing: Deprecate Opencensus (@1.30) Aug 16, 2023
Copy link
Member

@basvanbeek basvanbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy we're first deprecating with a notice. Personally I feel the OpenCensus project has been archived too early as OpenTelemetry has not been great at getting to production readiness (especially metrics in Go). But I do believe their decision has made it inevitable for us to get rid of non maintained code with some sense of urgency. This strikes a good balance for people needing to switch over.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] tracing: Deprecate Opencensus (@1.30) tracing: Deprecate Opencensus (@1.30) Aug 18, 2023
@@ -48,29 +48,35 @@ message OpenCensusConfig {
reserved 7;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htuch you may know why - the one thing i didnt manage to do was deprecate the enum above (in file)

not sure why - probs i was just doing it wrong

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably only matters that you deprecate the fields that reference it.

@yanavlasov yanavlasov merged commit dbf9fa8 into envoyproxy:main Aug 22, 2023
115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants