Config: Implement deferred clusters on worker. #28702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workers inline when there's traffic for that cluster. Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
KBaichoo
requested review from
wbpcode,
mattklein123 and
alyssawilk
as code owners
|
/assign @adisuissa |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
might make sense for adip to do api shepparding as well since he'll do the review. /unassign @mattklein123 |
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
adisuissa
reviewed
Jul 31, 2023
adisuissa
reviewed
Aug 3, 2023
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
KBaichoo
commented
Aug 3, 2023
adisuissa
approved these changes
Aug 4, 2023
|
@envoyproxy/senior-maintainers assignee is @mattklein123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Config: Implement deferred clusters on worker.
Additional Description: We initialize certain cluster types on workers inline when there's traffic for that cluster. This is a memory optimization for large envoy deployments with many clusters and workers. This will be followed up with an "eviction PR" so that the deferral benefits don't go away the longer the envoy process runs.
Risk Level: med / high
Testing: unit, integration
Docs Changes: included
Release Notes: included
Platform Specific Features: na
Runtime guard: Config guarded
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]