Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Dont stamp Envoy binary in Pull Requests #26776

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Apr 16, 2023

Fix #26632

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft April 16, 2023 15:12
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP/TESTING] ci: Dont stamp Envoy binary in Pull Requests ci: Dont stamp Envoy binary in Pull Requests Apr 16, 2023
@phlax phlax marked this pull request as ready for review April 16, 2023 21:40
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit ff37635 into envoyproxy:main Apr 16, 2023
mum4k pushed a commit to envoyproxy/nighthawk that referenced this pull request Apr 18, 2023
- Update the ENVOY_COMMIT and ENVOY_SHA in [bazel/repositories.bzl](https://github.com/envoyproxy/nighthawk/blob/main/bazel/repositories.bzl) to the latest Envoy's commit.
- Update [.bazelrc](https://github.com/envoyproxy/nighthawk/blob/main/.bazelrc) to match Envoy commit envoyproxy/envoy#26776
- Update [ci/run_envoy_docker.sh](https://github.com/envoyproxy/nighthawk/blob/main/ci/run_envoy_docker.sh) to match Envoy commit envoyproxy/envoy#26776
- Update [requirements.txt](https://github.com/envoyproxy/nighthawk/blob/main/requirements.txt]) with latest python dependencies

Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid stamping in PR builds and tests
2 participants