fix flake golang test. #26288
Merged
fix flake golang test. #26288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix envoyproxy#26182 it's due to sendData on terminated request could cause segfault. Signed-off-by: doujiang24 <doujiang24@gmail.com>
|
/review @wangfakang |
alyssawilk
approved these changes
Mar 23, 2023
ashishb-solo
pushed a commit
to ashishb-solo/envoy
that referenced
this pull request
Mar 24, 2023
fixes envoyproxy#26182 it's due to sendData on terminated request could cause segfault. Signed-off-by: doujiang24 <doujiang24@gmail.com> Signed-off-by: Ashish Banerjee <ashish.banerjee@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
fix #26182
it's due to sendData on terminated request could cause segfault.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]