Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump ubuntu-build-image:base -> 458cb49ca #25739

Merged
merged 2 commits into from
Feb 23, 2023
Merged

deps: Bump ubuntu-build-image:base -> 458cb49ca #25739

merged 2 commits into from
Feb 23, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Feb 23, 2023

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax
deps: Bump ubuntu-build-image:base -> 458cb49ca
f6a2e16 
Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Feb 23, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #25739 was opened by phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Feb 23, 2023

this should fix the missing run-clang-tidy.py issue cc @KBaichoo @adisuissa

cc @jpsim for mobile updates

KBaichoo
KBaichoo previously approved these changes Feb 23, 2023
View reviewed changes
jpsim
jpsim previously approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Either here or I can do as a followup, we should update the mobile-f52df4a4e1e2ecbcda42eb2f27a1550b6c53eef0 tags to point to mobile-458cb49ca2013c0ccf057d00ad1d4407920c4e52 so the next time we go to bump, we find all of them when grepping.

@phlax
bump-mobile-images-toolchains
25e249e 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax dismissed stale reviews from jpsim and KBaichoo via 25e249e February 23, 2023 14:56
@phlax
Copy link
Member Author

phlax commented Feb 23, 2023

@jpsim updated, hopefully correctly

jpsim
jpsim approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, CI willing

@phlax phlax enabled auto-merge (squash) February 23, 2023 14:58
@phlax phlax merged commit bd480aa into envoyproxy:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsim jpsim jpsim approved these changes

@KBaichoo KBaichoo KBaichoo left review comments

@Augustyniak Augustyniak Awaiting requested review from Augustyniak

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist is a code owner

@alyssawilk alyssawilk Awaiting requested review from alyssawilk alyssawilk is a code owner

@abeyad abeyad Awaiting requested review from abeyad abeyad is a code owner

Assignees

@mattklein123 mattklein123

Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phlax @jpsim @KBaichoo @mattklein123