Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Cleanups #25515

Merged
merged 1 commit into from
Feb 14, 2023
Merged

python: Cleanups #25515

merged 1 commit into from
Feb 14, 2023

Conversation

phlax
Copy link
Member

@phlax phlax commented Feb 13, 2023

  • remove unused bazel args
  • remove unused shebang lines
  • properly namespace imports

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft February 13, 2023 13:30
- remove unused bazel args
- remove unused shebang lines
- properly namespace imports

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] python: Cleanups python: Cleanups Feb 13, 2023
@phlax phlax marked this pull request as ready for review February 13, 2023 13:48
@phlax phlax merged commit ad9c2d5 into envoyproxy:main Feb 14, 2023
eric846 pushed a commit to envoyproxy/nighthawk that referenced this pull request Feb 21, 2023
- Update the ENVOY_COMMIT and ENVOY_SHA in [bazel/repositories.bzl](https://github.com/envoyproxy/nighthawk/blob/main/bazel/repositories.bzl) to the latest Envoy's commit.
- Update [.bazelrc](https://github.com/envoyproxy/nighthawk/blob/main/.bazelrc) to match Envoy commit envoyproxy/envoy#25515

Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants