-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: fix config_setting visibility issues #24237
bazel: fix config_setting visibility issues #24237
Conversation
This pulls in a googleurl patch that's waiting on upstream, and updates rules_go for compatibility with this flag. This also flips it early so we don't regress before it's flipped upstream. Fixes envoyproxy#24183 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though this PR is marked as draft so maybe it's not actually ready?
thanks! was just a draft in case of more surprises |
@@ -31,6 +31,9 @@ build --action_env=PATH --host_action_env=PATH | |||
build --enable_platform_specific_config | |||
build --test_summary=terse | |||
|
|||
# TODO(keith): Remove once this is the default | |||
build --incompatible_config_setting_private_default_visibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably have to enable --incompatible_enforce_config_setting_visibility
as well to make sure this actually take effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pulls in a googleurl patch that's waiting on upstream, and updates rules_go for compatibility with this flag. This also flips it early so we don't regress before it's flipped upstream.
Fixes #24183
Signed-off-by: Keith Smiley keithbsmiley@gmail.com