Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fixing brokend dead strip #23943

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

alyssawilk
Copy link
Contributor

Signed-off-by: Alyssa Wilk alyssar@chromium.org

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor Author

cc @jpsim @Augustyniak

@jpsim
Copy link
Contributor

jpsim commented Nov 14, 2022

Is there more context here? How can you tell it was broken before and how can you tell that this fixes the issue?

@keith
Copy link
Member

keith commented Nov 14, 2022

if nothing else --dead_strip isn't a valid arg to any linker, but definitely not at the same time as --gc-sections which is ELF only

@keith
Copy link
Member

keith commented Nov 14, 2022

I imagine we don't need either of those since bazel should be flipping those for us and solve the platform dependent issue

@alyssawilk
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23943 (comment) was created by @alyssawilk.

see: more, trace.

@alyssawilk alyssawilk merged commit 736fc7c into envoyproxy:main Nov 15, 2022
@alyssawilk alyssawilk deleted the size branch April 5, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants