-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: update to 6.0.0rc1 #23678
bazel: update to 6.0.0rc1 #23678
Conversation
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
3e17981
to
4cbce1a
Compare
ci/windows_ci_steps.sh
Outdated
@@ -88,7 +88,7 @@ fi | |||
|
|||
# Complete envoy-static build | |||
if [[ $BUILD_ENVOY_STATIC -eq 1 ]]; then | |||
bazel "${BAZEL_STARTUP_OPTIONS[@]}" build "${BAZEL_BUILD_OPTIONS[@]}" //source/exe:envoy-static | |||
bazel "${BAZEL_STARTUP_OPTIONS[@]}" build --output_groups=+pdb_file "${BAZEL_BUILD_OPTIONS[@]}" //source/exe:envoy-static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New requirement to force bazel to download this when using remote exec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont entirely understand why this is now required here but wondering if we need to add it anywhere else and/or update relevant docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it to the .bazelrc instead, which should eliminate the need for that for folks not using the scripts. the gist of it is that previously building cc_binary targets would always output the binary and the pdb file, now you have to explicitly request the pdb file, realistically I think this only applies to remote exec, which otherwise skips the download of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks for explanation
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @keith
project_url = "https://github.com/bazelbuild/rules_license", | ||
version = "0.0.3", | ||
sha256 = "00ccc0df21312c127ac4b12880ab0f9a26c1cff99442dc6c5a331750360de3c3", | ||
urls = ["https://github.com/bazelbuild/rules_license/releases/download/0.0.3/rules_license-0.0.3.tar.gz"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see this one come through - we shouldn't hard code the versions here. Should be
urls = ["https://github.com/bazelbuild/rules_license/releases/download/{version}/rules_license-{version}.tar.gz"],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops thanks! #23780
This reverts commit 84df237. Signed-off-by: Ryan Northey <ryan@synca.io>
No description provided.