-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: update bazel-toolchains to 5.1.2 #22862
bazel: update bazel-toolchains to 5.1.2 #22862
Conversation
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
c069f4e
to
9cd955a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the docker image as well? Otherwise we're using different build image in RBE vs non-RBE.
Since one wasn't built for my change, are you suggesting just updating to the latest built one, or forcing a build somehow? |
/lgtm deps |
A new one is built on my PR to envoy-build-tools. Follow https://github.com/envoyproxy/envoy/blob/main/.bazelrc#L292 to update those SHA references. |
theres a few places to update - b67521d has them all i think |
Fixes envoyproxy#22758 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
9cd955a
to
35fddc1
Compare
Updated update to envoyproxy/envoy-build-tools@b0ff77a |
/retest |
Retrying Azure Pipelines: |
Fixes #22758
Signed-off-by: Keith Smiley keithbsmiley@gmail.com