Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: update bazel-toolchains to 5.1.2 #22862

Merged

Conversation

keith
Copy link
Member

@keith keith commented Aug 26, 2022

Fixes #22758

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Aug 26, 2022
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #22862 was opened by keith.

see: more, trace.

@keith keith force-pushed the ks/bazel-update-bazel-toolchains-to-5.1.2 branch 2 times, most recently from c069f4e to 9cd955a Compare August 26, 2022 17:34
@keith keith enabled auto-merge (squash) August 26, 2022 17:37
Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the docker image as well? Otherwise we're using different build image in RBE vs non-RBE.

@keith
Copy link
Member Author

keith commented Aug 26, 2022

Since one wasn't built for my change, are you suggesting just updating to the latest built one, or forcing a build somehow?

@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Aug 26, 2022
@lizan
Copy link
Member

lizan commented Aug 29, 2022

A new one is built on my PR to envoy-build-tools. Follow https://github.com/envoyproxy/envoy/blob/main/.bazelrc#L292 to update those SHA references.

@phlax
Copy link
Member

phlax commented Aug 29, 2022

theres a few places to update - b67521d has them all i think

Fixes envoyproxy#22758

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keith keith force-pushed the ks/bazel-update-bazel-toolchains-to-5.1.2 branch from 9cd955a to 35fddc1 Compare September 2, 2022 00:11
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 2, 2022
@keith
Copy link
Member Author

keith commented Sep 2, 2022

Updated update to envoyproxy/envoy-build-tools@b0ff77a

@keith
Copy link
Member Author

keith commented Sep 2, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22862 (comment) was created by @keith.

see: more, trace.

@keith keith merged commit a785dd7 into envoyproxy:main Sep 2, 2022
@keith keith deleted the ks/bazel-update-bazel-toolchains-to-5.1.2 branch September 2, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please regenerate RBE toolchain configs
4 participants