docs: new parameter name for the bazel remote cache

[mkauf]

docs: new parameter name for the bazel remote cache

The bazel parameter '--remote_http_cache' has been renamed to
'--remote_cache'. Use the new name.

Signed-off-by: Michael Kaufmann michael.kaufmann@ergon.ch

Risk Level: Low

[repokitteh-read-only]

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22170/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #22170 was opened by mkauf.

see: more, trace.

[repokitteh-read-only]

Hi @mkauf, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #22170 was opened by mkauf.

see: more, trace.

[phlax]

@mkauf the flag change in bazel/README looks correct

regarding BAZEL_REMOTE_CACHE - is this automatically detected by bazel ?

im also wondering why not use the existing env var for this

cc @lizan

[mkauf]

@phlax

regarding BAZEL_REMOTE_CACHE - is this automatically detected by bazel ?

No, this environment variable is handled in setup_cache.sh (https://github.com/envoyproxy/envoy/blob/v1.22.2/ci/setup_cache.sh#L23)

[phlax]

i see, but then im wondering why change it - iiuc it is just going to set the BAZEL_BUILD_EXTRA_OPTIONS and skip the undocumented envoy ci setup

with the original way it gives the end user more flexibility because they can also pass other args that way - no ?

[mkauf]

I think the purpose of the environment variable BAZEL_REMOTE_CACHE is to pass the URL to the bazel remote cache. Of course, if you need more flexibility, then use BAZEL_BUILD_EXTRA_OPTIONS. (after all, it's just a change in the readme, not in the code)

But if you think that using BAZEL_REMOTE_CACHE is a bad idea, I can adjust the commit.

[phlax]

cool, lets keep the docs for BAZEL_BUILD_EXTRA_OPTIONS and adjust the docs for the RBE flags

[phlax]

@mkauf if you can rever the change to the extra_options env var then this should be good to land

[phlax]

/wait

[mkauf]

I have updated the pull request.

[phlax]

great, thanks @mkauf , lgtm