Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update image with deps upgrade #21278

Merged
merged 2 commits into from
May 16, 2022
Merged

Conversation

lizan
Copy link
Member

@lizan lizan commented May 13, 2022

Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 13, 2022
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #21278 was opened by lizan.

see: more, trace.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from ggreenway as a code owner May 13, 2022 06:37
@phlax
Copy link
Member

phlax commented May 13, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #21278 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Member

phlax commented May 13, 2022

seems this is reliably failing with

ragel/Makefile.am:2: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
WARNING: 'automake-1.15' is probably too old.
         You should only need it if you modified 'Makefile.am' or
         'configure.ac' or m4 files included by 'configure.ac'.
         The 'automake' program is part of the GNU Automake package:
         <[http://www.gnu.org/software/automake>](http://www.gnu.org/software/automake%3E)
         It also requires GNU Autoconf, GNU m4 and Perl in order to run:
         <[http://www.gnu.org/software/autoconf>](http://www.gnu.org/software/autoconf%3E)
         <[http://www.gnu.org/software/m4/>](http://www.gnu.org/software/m4/%3E)
         <[http://www.perl.org/>](http://www.perl.org/%3E)
Makefile:343: recipe for target '/b/f/w/external/net_colm_open_source_ragel/Makefile.in' failed

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @lizan

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label May 16, 2022
@phlax phlax merged commit 3efaecf into envoyproxy:main May 16, 2022
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants