aws: Refactor libcurl metadata fetcher to accept RequestMessage as argument #20954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
|
cc @tonya11en |
suniltheta
changed the title
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…gument (envoyproxy#20954) Signed-off-by: Sunil Narasimhamurthy <sunnrs@amazon.com>
suniltheta
added a commit
to suniltheta/envoy
that referenced
this pull request
Oct 7, 2022
…ge as argument (envoyproxy#20954)" This reverts commit bf675a8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: aws: Refactor libcurl metadata fetcher to accept RequestMessage as argument
Additional Description: This is the first commit in the overall effort to remove dependency on libcurl for AWS extensions #11816. This doesn't have much functional change but more of refactoring necessary to introduce a new class MetadataFetcher which will inherit from
Http::AsyncClient::Callbacks.Risk Level: Low
Testing:
Docs Changes: NA
Release Notes: NA
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]