Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: disable wasm on macOS for now #20889

Merged

Conversation

keith
Copy link
Member

@keith keith commented Apr 19, 2022

On M1 macs this fails with a linker error that I'm attempting to fix
here https://chromium-review.googlesource.com/c/v8/v8/+/3589296

We could also take that as a patch but it would probably be nice to get
input upstream on the fix first.

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

On M1 macs this fails with a linker error that I'm attempting to fix
here https://chromium-review.googlesource.com/c/v8/v8/+/3589296

We could also take that as a patch but it would probably be nice to get
input upstream on the fix first.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Copy link
Contributor

@alecholmez alecholmez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snowp this was super helpful for me building on M1 machines, any interesting in getting this reviewed/merged?

@jmarantz jmarantz merged commit 823f81e into envoyproxy:main Apr 20, 2022
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
On M1 macs this fails with a linker error that I'm attempting to fix
here https://chromium-review.googlesource.com/c/v8/v8/+/3589296

We could also take that as a patch but it would probably be nice to get
input upstream on the fix first.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@dio dio mentioned this pull request Sep 16, 2022
6 tasks
@dio
Copy link
Member

dio commented Sep 24, 2022

@keith should we do build:macos --define wasm=wasmtime instead? cc. @cpakulski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants