Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: try gcloud resultstore #20729

Merged
merged 10 commits into from
May 5, 2022
Merged

ci: try gcloud resultstore #20729

merged 10 commits into from
May 5, 2022

Conversation

lizan
Copy link
Member

@lizan lizan commented Apr 8, 2022

Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #20729 was opened by lizan.

see: more, trace.

@lizan
Copy link
Member Author

lizan commented Apr 11, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #20729 (comment) was created by @lizan.

see: more, trace.

lizan added 7 commits May 4, 2022 15:16
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan marked this pull request as ready for review May 5, 2022 06:24
@lizan lizan requested a review from alyssawilk May 5, 2022 06:25
@lizan
Copy link
Member Author

lizan commented May 5, 2022

@alyssawilk had to revert #21073 because the invocation ID and URLs are printed in as INFO.

@alyssawilk
Copy link
Contributor

:-( Totally fair though - honestly half the reason I wanted the logspam gone was to see test results cleanly and if the link works I don't have to troll through logs. And so exciting to have build results!

@alyssawilk
Copy link
Contributor

actually cc @keith is there trivial a way to have the info logs silenced for the build phase and not for the test phase?

@keith
Copy link
Member

keith commented May 5, 2022

I don't think so, theoretically we could build first and then test, but likely that would impact overall CI time since we'd lose some parallelization. We should try to track down why there were so many empty INFO logs instead to fix now I think

@lizan lizan merged commit 4734f0e into envoyproxy:main May 5, 2022
@lizan lizan deleted the ci_bes branch May 5, 2022 18:57
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants