Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: Remove cl.exe compiler workarounds for googleurl #20661

Conversation

keith
Copy link
Member

@keith keith commented Apr 4, 2022

The issue linked to this was closed over a year ago #11974

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #20661 was opened by keith.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 4, 2022
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #20661 was opened by keith.

see: more, trace.

@keith
Copy link
Member Author

keith commented Apr 4, 2022

cc @dio, if I'm reading this right this is probably safe? I want to see what CI says either way

@dio
Copy link
Member

dio commented Apr 4, 2022

@keith seems like so. Thanks for the cleanup!

@keith keith marked this pull request as ready for review April 4, 2022 23:32
@keith keith enabled auto-merge (rebase) April 4, 2022 23:32
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wh00t, thanks!
/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Apr 5, 2022
@keith
Copy link
Member Author

keith commented Apr 5, 2022

Hrm maybe the comments were outdated:

# Execution platform: @envoy_build_tools//toolchains:rbe_windows_msvc_cl_platform
external/com_googlesource_googleurl\base/compiler_specific.h(11): fatal error C1189: #error:  "Only clang-cl is supported on Windows, see [https://crbug.com/988071"](https://crbug.com/988071%22)

@keith keith marked this pull request as draft April 8, 2022 07:52
auto-merge was automatically disabled April 8, 2022 07:52

Pull request was converted to draft

@github-actions
Copy link

github-actions bot commented May 8, 2022

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 8, 2022
@keith keith closed this May 9, 2022
@keith keith deleted the ks/bazel-remove-cl.exe-compiler-workarounds-for-googleurl branch May 9, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants