-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: Remove cl.exe compiler workarounds for googleurl #20661
bazel: Remove cl.exe compiler workarounds for googleurl #20661
Conversation
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
cc @dio, if I'm reading this right this is probably safe? I want to see what CI says either way |
@keith seems like so. Thanks for the cleanup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wh00t, thanks!
/lgtm deps
Hrm maybe the comments were outdated:
|
Pull request was converted to draft
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
The issue linked to this was closed over a year ago #11974
Signed-off-by: Keith Smiley keithbsmiley@gmail.com