docs: mov tag guard to release build#2056
Merged
mattklein123 merged 2 commits intomasterfrom Nov 13, 2017
Merged
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
htuch
reviewed
Nov 13, 2017
ci/do_ci.sh
Outdated
| } | ||
|
|
||
| if [[ "$1" == "bazel.release" ]]; then | ||
| if [ -n "$CIRCLE_TAG" ] |
Member
There was a problem hiding this comment.
As a general nit, the style guide prefers [[ over [ I believe.
ci/do_ci.sh
Outdated
| } | ||
|
|
||
| if [[ "$1" == "bazel.release" ]]; then | ||
| if [ -n "$CIRCLE_TAG" ] |
Member
There was a problem hiding this comment.
Can you add a comment explaining why this is necessary?
Member
Author
|
@htuch updated |
htuch
approved these changes
Nov 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.