runtime: no longer using runtime singleton #20337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
runtime_followup
branch
2 times, most recently
from
9bfad05
to
e61753c
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
runtime_followup
branch
from
e61753c
to
ce1ad14
Compare
|
Check CI? /wait |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
CodeQL is not related to code changes, it is a network issue. |
daixiang0
approved these changes
Mar 17, 2022
KBaichoo
added a commit
to KBaichoo/envoy
that referenced
this pull request
Mar 18, 2022
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
This PR has a pretty high chance of CI breaking post-submit, as anyone else who references global runtime will have clean merges, but have their tests fail. Risk Level: Low for upstream Envoy, high of downstream test breakages. Testing: n/a Docs Changes: n/a Release Notes: inline Actually fixes envoyproxy#19847 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a pretty high chance of CI breaking post-submit, as anyone else who references global runtime will have clean merges, but have their tests fail.
Risk Level: Low for upstream Envoy, high of downstream test breakages.
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Actually fixes #19847