Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrib coverage #19867

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Contrib coverage #19867

merged 2 commits into from
Feb 8, 2022

Conversation

durd07
Copy link
Member

@durd07 durd07 commented Feb 8, 2022

Commit Message: include contrib source coverage
Additional Description: fix the issue that bazel coverage doesn't do coverage of source code in contrib
Risk Level: low
Testing: unit tests
Docs Changes: n/a
Release Notes: inline
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #19729
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Felix Du <durd07@gmail.com>
Signed-off-by: Felix Du <durd07@gmail.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 94c44ec into envoyproxy:main Feb 8, 2022
@durd07 durd07 deleted the contrib-coverage branch February 9, 2022 00:20
joshperry pushed a commit to joshperry/envoy that referenced this pull request Feb 13, 2022
fix the issue that bazel coverage doesn't do coverage of source code in contrib

Fixes envoyproxy#19729

Signed-off-by: Felix Du <durd07@gmail.com>
Signed-off-by: Josh Perry <josh.perry@mx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants