-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add config to enable looking up local interface name for upstream connections #19758
Conversation
…ame for upstream connections Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
/wait-any |
Signed-off-by: Jose Nino <jnino@lyft.com>
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Jose Nino <jnino@lyft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alyssawilk I managed to string config through all the way. It took a moment because there was no clear way to do so outside of the pattern established for SOCKET_OPTIONS. Lmk what you think.
/wait-any |
@yanavlasov @alyssawilk @markdroth updated! |
Signed-off-by: Jose Nino <jnino@lyft.com>
Looks like CI is not happy. /wait |
Signed-off-by: Jose Nino <jnino@lyft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending windows CI :-)
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Looks like windows still needs a pass |
cc @oschaaf we should backport this. |
No news on a backport ? |
cc @pradeepcrao |
I will get to this end of this week. |
name for upstream connections (envoyproxy#19758) Signed-off-by: Pradeep Rao <pcrao@google.com>
…am connections (envoyproxy#19758) * connection: add runtime guard to disable looking up local interface name for upstream connections Signed-off-by: Jose Nino <jnino@lyft.com>
Commit Message: add config to enable looking up local interface name for upstream connections
Risk Level: low, bug fix
Testing: integration test
Release Notes: added
Runtime guard: envoy.reloadable_features.disable_local_interface_name_for_upstream_connection
Fixes #19717