perf: add config to enable looking up local interface name for upstream connections #19758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2022 15:04
…ame for upstream connections Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
junr03
commented
Jan 31, 2022
|
/wait-any |
Signed-off-by: Jose Nino <jnino@lyft.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Jose Nino <jnino@lyft.com>
junr03
commented
Feb 4, 2022
There was a problem hiding this comment.
@alyssawilk I managed to string config through all the way. It took a moment because there was no clear way to do so outside of the pattern established for SOCKET_OPTIONS. Lmk what you think.
added 3 commits
February 4, 2022 09:59
markdroth
reviewed
Feb 7, 2022
junr03
changed the title
|
/wait-any |
|
@yanavlasov @alyssawilk @markdroth updated! |
Signed-off-by: Jose Nino <jnino@lyft.com>
|
Looks like CI is not happy. /wait |
Signed-off-by: Jose Nino <jnino@lyft.com>
alyssawilk
previously approved these changes
Mar 14, 2022
added 3 commits
March 14, 2022 15:34
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
|
Looks like windows still needs a pass |
alyssawilk
approved these changes
Mar 16, 2022
yanavlasov
approved these changes
Mar 16, 2022
|
cc @oschaaf we should backport this. |
|
No news on a backport ? |
|
cc @pradeepcrao |
|
I will get to this end of this week. |
pradeepcrao
added a commit
to pradeepcrao/envoy
that referenced
this pull request
Apr 16, 2022
name for upstream connections (envoyproxy#19758) Signed-off-by: Pradeep Rao <pcrao@google.com>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…am connections (envoyproxy#19758) * connection: add runtime guard to disable looking up local interface name for upstream connections Signed-off-by: Jose Nino <jnino@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: add config to enable looking up local interface name for upstream connections
Risk Level: low, bug fix
Testing: integration test
Release Notes: added
Runtime guard: envoy.reloadable_features.disable_local_interface_name_for_upstream_connection
Fixes #19717