Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: envoy.reloadable_features.internal_redirects_with_body deprecation #19670

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

daixiang0
Copy link
Member

Signed-off-by: Loong loong.dai@intel.com

Commit Message: http: envoy.reloadable_features.internal_redirects_with_body deprecation
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #19506
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@daixiang0
Copy link
Member Author

/wait

@daixiang0
Copy link
Member Author

/wait

@daixiang0
Copy link
Member Author

/wait

@alyssawilk
Copy link
Contributor

/wait on CI :-)

@daixiang0
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19670 (comment) was created by @daixiang0.

see: more, trace.

@daixiang0
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19670 (comment) was created by @daixiang0.

see: more, trace.

@daixiang0
Copy link
Member Author

It is wired that x86 pass but arm fails.

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up!

@alyssawilk alyssawilk enabled auto-merge (squash) February 9, 2022 16:43
@alyssawilk
Copy link
Contributor

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #19670 (comment) was created by @alyssawilk.

see: more, trace.

@alyssawilk alyssawilk merged commit 863b035 into envoyproxy:main Feb 10, 2022
@daixiang0 daixiang0 deleted the internal_redirects_with_body branch February 11, 2022 02:31
joshperry pushed a commit to joshperry/envoy that referenced this pull request Feb 13, 2022
…ion (envoyproxy#19670)

Commit Message: http: envoy.reloadable_features.internal_redirects_with_body deprecation
[Optional Fixes #Issue] envoyproxy#19506

Signed-off-by: Loong <loong.dai@intel.com>
Signed-off-by: Josh Perry <josh.perry@mx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants