-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quiche: patch for MacOS build #19360
Conversation
Signed-off-by: Jose Nino <jnino@lyft.com>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
@RyanTheOptimist @htuch I found this type constraint error when updating Envoy in Envoy Mobile. I'll work on a quiche upstream patch to remove the local patch here. However, for the time being it would be nice to patch locally in order to unblock bringing Envoy into Envoy Mobile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@birenroy can you backport this fix? I wonder if we're building this on chromium, which also has a mac OS build
Awesome @RyanTheOptimist if @birenroy can help us with that I will sight tight :) |
Yeah, the actual source of truth for quiche is a google-internal repo so a Googler will have to land the fix at the end of the day. Hopefully one day we'll move to an open-source-first model for quiche! |
/lgtm deps |
/retest |
Retrying Azure Pipelines: |
/retest |
Retrying Azure Pipelines: |
Fixes issues reported in pull requests: envoyproxy/envoy#19360 envoyproxy/envoy#19408 PiperOrigin-RevId: 419931794
quiche: patch for macOS build The patch from #19360 and other similar implicit type cast fixes have now landed upstream in quiche, so this PR bumps quiche to b0fda33 and deletes the local patch as it is no longer needed. Changes: google/quiche@c8c21d0...b0fda33 Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
quiche: patch for macOS build The patch from envoyproxy#19360 and other similar implicit type cast fixes have now landed upstream in quiche, so this PR bumps quiche to b0fda33 and deletes the local patch as it is no longer needed. Changes: google/quiche@c8c21d0...b0fda33 Signed-off-by: JP Simard <jp@jpsim.com> Signed-off-by: Josh Perry <josh.perry@mx.com>
Signed-off-by: Jose Nino jnino@lyft.com