bazel: Use --experimental_allow_tags_propagation
#18913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows tags to influence execution requirements. There is already one use of `no-remote` in this repo, but this is also needed by envoy-mobile, so I thought it was best to add here. Signed-off-by: Brentley Jones <brentleyjones@lyft.com>
|
Hi @brentleyjones, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
/retest |
|
Retrying Azure Pipelines: |
|
Tests are all green now. |
yanavlasov
approved these changes
Nov 12, 2021
lizan
approved these changes
Nov 12, 2021
brentleyjones
deleted the
bj/bazel-use-experimental_allow_tags_propagation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Use
--experimental_allow_tags_propagationwith bazel.Additional Description: This allows tags to influence execution requirements. There is already one use of
no-remotein this repo, but this is also needed by envoy-mobile, so I thought it was best to add here.Risk Level: Low.
Testing: Local builds.
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.