Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: fix build with --config=docker-asan. #18629

Merged
merged 1 commit into from
Oct 18, 2021
Merged

bazel: fix build with --config=docker-asan. #18629

merged 1 commit into from
Oct 18, 2021

Conversation

PiotrSikora
Copy link
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

@PiotrSikora
bazel: fix build with --config=docker-asan.
a74243b 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Copy link
Contributor Author

@lizan @phlax the docker image ships with LLVM 12.0.1, but rbe-toolchain-asan still points to 11.0.1, which breaks builds with --config=docker-asan. However, it seems that ASan builds work fine on the CI. Any ideas why it's not broken there?

@lizan
Copy link
Member

lizan commented Oct 18, 2021

@PiotrSikora looks like CI doesn't use rbe-toolchain-asan but use the clang setup script to detect this path.

@lizan lizan merged commit 57949bc into envoyproxy:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizan lizan lizan approved these changes

Assignees

@phlax phlax

@lizan lizan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PiotrSikora @lizan @phlax