Fix debug build. #181
Merged
Fix debug build. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattklein123
approved these changes
Oct 31, 2016
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this pull request
Oct 10, 2019
Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
Mar 4, 2020
This is similar to the http2 frame protection, but rather than try to guard [header block || last body bytes || last chunk in chunk encoding || trailer block] depending on end stream, which just gets messy, I opted to just add an empty reference counted fragment after the body was serialized, which appears to work just as well with a small theoretical overhead. If folks think the complexity is warranted I can of course do that instead. Risk Level: Medium Testing: new unit tests, integration test Docs Changes: stats documented Release Notes: added Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Co-authored-by: Lizan Zhou <lizan@tetrate.io>
mattklein123
added a commit
that referenced
this pull request
Jun 30, 2020
Fixes envoyproxy/envoy-setec#180 Signed-off-by: Matt Klein <mklein@lyft.com>
PiotrSikora
added a commit
that referenced
this pull request
Jun 30, 2020
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
added a commit
that referenced
this pull request
Jun 30, 2020
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
pushed a commit
that referenced
this pull request
Jun 30, 2020
Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Tony Allen <tony@allen.gg>
stedsome
pushed a commit
to stedsome/envoy
that referenced
this pull request
Jun 30, 2020
) Fixes envoyproxy/envoy-setec#180 Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Yifan Yang <needyyang@google.com>
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
…nfiguration zh-translation: docs/root/intro/arch_overview/operations/dynamic_conf…
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino jnino@lyft.com Description: This PR concludes binary size investigation slated for issue #17. The three deliverables of this PR are: 1. Developer documentation that solidifies the building and analysis platform used for binary size analysis. 2. A list of issues for next steps in binary size reduction under the perf/size label. 3. A final baseline size for the binary: As of https://github.com/lyft/envoy-mobile/tree/11530fe10212778d811657823f3fde23425cdd28 The test_binary_size_size as built by the toolchain against the architecture described (arm64 with clang and lld) compiles to a stripped size of 8.9mb and a compressed size of 3mb. Additionally #181 will add CI jobs to add size regression analysis on every PR. Risk Level: low - add new bazel target and docs. Docs Changes: added developer documentation. Fixes #17 Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino jnino@lyft.com Description: after #173 landed this target broke due to the breaking API change. This target will be added to CI once #181 closes, so breakages like this will not go undected. Risk Level: low - updating API, deleting old build rules. Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino jnino@lyft.com Description: This PR concludes binary size investigation slated for issue #17. The three deliverables of this PR are: 1. Developer documentation that solidifies the building and analysis platform used for binary size analysis. 2. A list of issues for next steps in binary size reduction under the perf/size label. 3. A final baseline size for the binary: As of https://github.com/lyft/envoy-mobile/tree/11530fe10212778d811657823f3fde23425cdd28 The test_binary_size_size as built by the toolchain against the architecture described (arm64 with clang and lld) compiles to a stripped size of 8.9mb and a compressed size of 3mb. Additionally #181 will add CI jobs to add size regression analysis on every PR. Risk Level: low - add new bazel target and docs. Docs Changes: added developer documentation. Fixes #17 Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino jnino@lyft.com Description: after #173 landed this target broke due to the breaking API change. This target will be added to CI once #181 closes, so breakages like this will not go undected. Risk Level: low - updating API, deleting old build rules. Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.