Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: rename address provider variable name #17888

Merged

Conversation

soulxu
Copy link
Member

@soulxu soulxu commented Aug 27, 2021

Commit Message: network: rename address provider variable name
Additional Description:
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Part of #17168

Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
@soulxu soulxu reopened this Aug 27, 2021
@soulxu soulxu force-pushed the rename_socket_address_varible_name branch from bf0bde4 to fa0c9f9 Compare August 27, 2021 02:24
@soulxu
Copy link
Member Author

soulxu commented Aug 27, 2021

cc @mattklein123

@mattklein123
Copy link
Member

Needs a main merge unfortunately.

/wait

Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 05ca792 into envoyproxy:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants