Revert "upstream: avoid reset after end_stream in TCP HTTP upstream (… #14551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvoyproxy#14106)" This reverts commit 1c06967. Signed-off-by: Snow Pettersen <snowp@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#14106)"
This reverts commit 1c06967.
After some digging it appears that we can avoid the issue that prompted me to put this PR up to begin with by carefully destroying the upstream at the right time, so I don't think this change is necessary. Given @mattklein123's feedback on
the original PR it seems prudent to just revert this change.
Signed-off-by: Snow Pettersen snowp@lyft.com
Risk Level: Low
Testing: n/a, revert
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a