-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "ext_auth: add option to measure timeout when check request is created. (#12778)" #14152
Conversation
… created. (envoyproxy#12778)" This reverts commit dfa85e8. Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/retest I think a CI issue, as it failed building |
Retrying Azure Pipelines: |
Looks like legit CI issue. /wait |
weird, as it builds fine locally. will try re-building with the exact clang version. |
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
ok, merging latest master reproduced the failure; fixing |
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
@@ -14,6 +14,7 @@ | |||
|
|||
#include "test/common/stats/stat_test_utility.h" | |||
#include "test/mocks/config/mocks.h" | |||
#include "test/mocks/event/mocks.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed in the revert? Seems unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my code I added it to mocks/grpc/mocks.h,so it was included transitivly.. after the revert it is no longer in grpc/mocks.h
/retest |
Retrying Azure Pipelines: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Commit Message:
Revert "ext_auth: add option to measure timeout when check request is created. (#12778)"