Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: replace ad-hoc [0, 1] value types with UnitFloat #14081

Merged
merged 7 commits into from
Dec 1, 2020
Merged

cleanup: replace ad-hoc [0, 1] value types with UnitFloat #14081

merged 7 commits into from
Dec 1, 2020

Commits on Nov 18, 2020

  1. Replace ad-hoc [0, 1] value types with UnitFloat 

    Add IntervalValue and its specialization UnitFloat, and use them to
guarantee that ScaledMinimum's scale_factor_ is in the range [0, 1].
Also do the same for OverloadActionState, and replace
ScaledTimerManagerImpl::DurationScaleFactor with UnitFloat, which is a
functional no-op.

Signed-off-by: Alex Konradi <akonradi@google.com>
    @akonradi
    akonradi committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    f22a548 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Fix test and change name 

    Signed-off-by: Alex Konradi <akonradi@google.com>
    @akonradi
    akonradi committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    4c457c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Add TODO for C++20 

    Signed-off-by: Alex Konradi <akonradi@google.com>
    @akonradi
    akonradi committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    72d8755 View commit details
    Browse the repository at this point in the history

  2. Mark static functions constexpr 

    Signed-off-by: Alex Konradi <akonradi@google.com>
    @akonradi
    akonradi committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    f95e89b View commit details
    Browse the repository at this point in the history

  3. Add interval unit tests 

    CI complained about coverage, so try adding tests

Signed-off-by: Alex Konradi <akonradi@google.com>
    @akonradi
    akonradi committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    69a6de1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/envoyproxy/envoy into uni… 

    …t-interval-type

Signed-off-by: Alex Konradi <akonradi@google.com>
    @akonradi
    akonradi committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    64b8c37 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Fix build 

    Signed-off-by: Alex Konradi <akonradi@google.com>
    @akonradi
    akonradi committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    ac126f1 View commit details
    Browse the repository at this point in the history