Use pyyaml safe_load #12534
Merged
Use pyyaml safe_load #12534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
lizan
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Replace pyyaml.load with pyyaml.safe_load
Additional Description:
From my testing there doesnt seem to be any problem switching to
safe_loadin protodocIm not sure whether the use in
config_validationrequires aFullLoaderbut i think if it does we should comment it insteadRisk Level: medium without being fixed
Testing: rebuilding docs has been tested with the change to the protodoc compiler
Docs Changes: n/a
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fixes #12533
[Optional Deprecated:]