[Windows] Enables various common network tests #12503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
@envoyproxy/windows-dev |
davinci26
changed the title
added 2 commits
August 5, 2020 12:59
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
wrowe
approved these changes
Aug 5, 2020
dio
approved these changes
Aug 5, 2020
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
This patch enables the following tests on Windows: 1. //test/common/http:codec_client_test 2. //test/common/network:listener_impl_test 3. //test/common/network:connection_impl_test To do so we swap the addresses to use `getCanonicalLoopbackAddress` instead of `getAnyAddress` and we add synchronization in `ConnectionImplTest.ReadWatermarks` tests. Additional Description: N/A Risk Level: Low, test only Testing: Updated unit tests Docs Changes: N/A Release Notes: N/A Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
This patch enables the following tests on Windows: 1. //test/common/http:codec_client_test 2. //test/common/network:listener_impl_test 3. //test/common/network:connection_impl_test To do so we swap the addresses to use `getCanonicalLoopbackAddress` instead of `getAnyAddress` and we add synchronization in `ConnectionImplTest.ReadWatermarks` tests. Additional Description: N/A Risk Level: Low, test only Testing: Updated unit tests Docs Changes: N/A Release Notes: N/A Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:
This patch enables the following tests on Windows:
To do so we swap the addresses to use
getCanonicalLoopbackAddressinstead ofgetAnyAddressand we add synchronization inConnectionImplTest.ReadWatermarkstests.Additional Description: N/A
Risk Level: Low
Testing: Unit tests changed
Docs Changes: N/A
Release Notes: N/A