hcm: move StreamInfo and filter creation into FM #12470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces FilterManagerCallbacks which can be used by the FM to call back out with the encoded data. This interface will be expanded as more functionalitiy is split between the ActiveStream and the FilterManager. Also makes the majority of FM functions private, relying on befriending the filter wrappers and a more well defined interface for the ActiveStream to pass headers/data to be decoded by the FM. Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <kpettersen@netflix.com>
Signed-off-by: Snow Pettersen <aickck@gmail.com>
|
An alternative approach would be to keep the StreamInfo at the AS level but pass a mutable ref to the filter manager via its ctor, which might be better? Open for suggestions here |
snowp
commented
Aug 4, 2020
| @@ -533,8 +534,12 @@ ConnectionManagerImpl::ActiveStream::ActiveStream(ConnectionManagerImpl& connect | |||
| connection_manager.config_.scopedRouteConfigProvider() == nullptr)), | |||
| "Either routeConfigProvider or scopedRouteConfigProvider should be set in " | |||
| "ConnectionManagerImpl."); | |||
| for (const AccessLog::InstanceSharedPtr& access_log : connection_manager_.config_.accessLogs()) { | |||
There was a problem hiding this comment.
This pushes the access logs via the config onto the same list as the ones coming via the filter factory, so we avoid having to loop over both this and the list of registered access logs in the FM dtor
Signed-off-by: Snow Pettersen <aickck@gmail.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Moves the ownership of the StreamInfoImpl into the FilterManager, exposed via an accessor to allow the ActiveStream to still modify/read the StreamInfo. Moves the interaction with the FilterChainFactory into the FilterManager, as well as ownership over the access logs created via the factory callbacks. Signed-off-by: Snow Pettersen <aickck@gmail.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Moves the ownership of the StreamInfoImpl into the FilterManager, exposed via an accessor to allow the ActiveStream to still modify/read the StreamInfo. Moves the interaction with the FilterChainFactory into the FilterManager, as well as ownership over the access logs created via the factory callbacks. Signed-off-by: Snow Pettersen <aickck@gmail.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the ownership of the
StreamInfoImplinto the FilterManager, exposed via an accessor to allow the ActiveStream tostill modify/read the StreamInfo.
Moves the interaction with the FilterChainFactory into the FilterManager, as well as ownership over the access logs created
via the factory callbacks.
Risk Level: Medium
Testing: Existing tests
Docs Changes: n/a
Release Notes: n/a
Part of #10454