bugfix: check_format script, tokenInLine helper function #12441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yifan Yang <needyyang@google.com>
|
@stedsome can you add a test to the code format checker that demonstrates this issue? |
|
@sunjayBhatia |
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
Signed-off-by: Yifan Yang <needyyang@google.com>
dio
approved these changes
Aug 4, 2020
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
…12441) Signed-off-by: Yifan Yang <needyyang@google.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
…12441) Signed-off-by: Yifan Yang <needyyang@google.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yifan Yang needyyang@google.com
This looks like a bug to me. @sunjayBhatia do you mind confirming this?
The effect of this is that this function incorrectly returns false when the token in question is the first one in a line.
This was found during my attempt here #12421.
Commit Message:
Additional Description:
Risk Level: low, should correct an incorrect behavior.
Testing: All existing tests have passed
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]