[test] fix flag in codec test new/legacy #12412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
mattklein123
previously approved these changes
Jul 31, 2020
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
dio
approved these changes
Aug 3, 2020
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Commit Message: fix runtime flag override in tests. There was a mistake that codec_impl_test for H/2 tested legacy and codec_impl_legacy_test tested new codec. Swap back so codec tests new, legacy tests legacy. Risk Level: Low Signed-off-by: Asra Ali <asraa@google.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Commit Message: fix runtime flag override in tests. There was a mistake that codec_impl_test for H/2 tested legacy and codec_impl_legacy_test tested new codec. Swap back so codec tests new, legacy tests legacy. Risk Level: Low Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Commit Message: fix runtime flag override in tests. There was a mistake that codec_impl_test for H/2 tested legacy and codec_impl_legacy_test tested new codec. Swap back so codec tests new, legacy tests legacy. Risk Level: Low Signed-off-by: Asra Ali <asraa@google.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: codec_impl_test for H/2 tested legacy, codec_impl_legacy_test tested new
Risk Level: Low
Signed-off-by: Asra Ali asraa@google.com