build: Update ICU and googleurl #12376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@danzh2010 could you help to provide the googleurl static snapshot for https://quiche.googlesource.com/googleurl/+/ef0d23689e240e6c8de4c3a5296b209128c87373, please? Thank you! |
|
Up loaded to
https://storage.googleapis.com/quiche-envoy-integration/googleurl_ef0d23689e240e6c8de4c3a5296b209128c87373.tar.gz
checksum: d769283fed1319bca68bae8bdd47fbc3a7933999329eee850eff1f1ea61ce176
…On Wed, Aug 5, 2020 at 2:17 AM Dhi Aurrahman ***@***.***> wrote:
@danzh2010 <https://github.com/danzh2010> could you help to provide the
googleurl static snapshot for
https://quiche.googlesource.com/googleurl/+/ef0d23689e240e6c8de4c3a5296b209128c87373,
please? Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12376 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AET6FQXRRXX535NSVQIFSEDR7D2P5ANCNFSM4PNTV6OA>
.
|
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
|
@lizan when you have time could you PTAL? Thanks! |
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
lizan
approved these changes
Aug 7, 2020
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
This patch updates ICU to 67.1 and googleurl to https://quiche.googlesource.com/googleurl/+/ef0d23689e240e6c8de4c3a5296b209128c87373. This reduces `bazel/external/googleurl.patch` to only handling MSVC quirks. Please note that googleurl direction for Windows is to use clang-cl, while we still use msvc-cl (hence the patch). Risk Level: Low Testing: Existing Docs Changes: N/A Release Notes: N/A Fixes envoyproxy#12015 Signed-off-by: Dhi Aurrahman <dio@tetrate.io> Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: This patch updates ICU to 67.1 and googleurl to https://quiche.googlesource.com/googleurl/+/ef0d23689e240e6c8de4c3a5296b209128c87373. This reduces
bazel/external/googleurl.patchto only handling MSVC quirks.Please note that googleurl direction for Windows is to use clang-cl, while we still use msvc-cl (hence the patch).
Risk Level: Low
Testing: Existing
Docs Changes: N/A
Release Notes: N/A
Fixes #12015