-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix refs in Lua docs #12313
Merged
Merged
docs: Fix refs in Lua docs #12313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a docs only change, mostly on how to refer to LuaPerRoute info. Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
CI failure:
|
@dio please open issues for test flakes that don't already have "test flake" issues opened. Thank you! |
Submitted the test flake here: #12325 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
alyssawilk
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alas for the overenthusiastic spaces ;-)
mattklein123
approved these changes
Jul 28, 2020
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
This is a docs only change, mostly on how to refer to LuaPerRoute info. Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
This is a docs only change, mostly on how to refer to LuaPerRoute info. Signed-off-by: Dhi Aurrahman <dio@tetrate.io> Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
This is a "docs" only change, mostly on how to refer to LuaPerRoute info (previously it was not rendered properly in the docs) and cleaning up some superfluous empty spaces.
Signed-off-by: Dhi Aurrahman dio@tetrate.io
Risk Level: Low
Testing: N/A
Docs Changes: Docs only
Release Notes: N/A