Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix refs in Lua docs #12313

Merged
merged 1 commit into from
Jul 28, 2020
Merged

docs: Fix refs in Lua docs #12313

merged 1 commit into from
Jul 28, 2020

Conversation

dio
Copy link
Member

@dio dio commented Jul 27, 2020

Commit Message:

This is a "docs" only change, mostly on how to refer to LuaPerRoute info (previously it was not rendered properly in the docs) and cleaning up some superfluous empty spaces.

Signed-off-by: Dhi Aurrahman dio@tetrate.io

Risk Level: Low
Testing: N/A
Docs Changes: Docs only
Release Notes: N/A

This is a docs only change, mostly on how to refer to LuaPerRoute info.

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #12313 was opened by dio.

see: more, trace.

@dio
Copy link
Member Author

dio commented Jul 28, 2020

CI failure:

2020-07-27T23:58:47.7033642Z //test/integration:integration_test                                      FAILED in 1 out of 2 in 32.7s

@mattklein123
Copy link
Member

@dio please open issues for test flakes that don't already have "test flake" issues opened. Thank you!

@dio
Copy link
Member Author

dio commented Jul 28, 2020

Submitted the test flake here: #12325

@dio
Copy link
Member Author

dio commented Jul 28, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alas for the overenthusiastic spaces ;-)

@alyssawilk alyssawilk self-assigned this Jul 28, 2020
@mattklein123 mattklein123 merged commit 3dedf16 into envoyproxy:master Jul 28, 2020
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
This is a docs only change, mostly on how to refer to LuaPerRoute info.

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
This is a docs only change, mostly on how to refer to LuaPerRoute info.

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants