Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zookeeper: note available latency stats in docs #12261

Merged
merged 3 commits into from
Jul 27, 2020
Merged

zookeeper: note available latency stats in docs #12261

merged 3 commits into from
Jul 27, 2020

Conversation

rgs1
Copy link
Member

@rgs1 rgs1 commented Jul 23, 2020

This was missed in #7825.

Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com

zookeeper: note available latency stats in docs
0702db9 
This was missed in envoyproxy#7825.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
@zuercher zuercher self-assigned this Jul 24, 2020
zuercher
zuercher reviewed Jul 24, 2020
View reviewed changes
Copy link
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we should just list the latency stat in the table, as with other extensions.

Raul Gutierrez Segales added 2 commits July 24, 2020 17:08
Merge remote-tracking branch 'upstream/master' into zookeeper-proxy-l…
f402949 
…atency-stats-update-docs
Add dedicated session for opcode latency stats
d5673bf 
Also adds table and enumerates latency stats.

Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
@rgs1
Copy link
Member Author

rgs1 commented Jul 24, 2020

Thanks! I think we should just list the latency stat in the table, as with other extensions.

I added a separate table, to keep the current one short. LMK if it makes sense.

@rgs1
Copy link
Member Author

rgs1 commented Jul 27, 2020

The pre-submit error is unrelated:

WARNING: Download from https://mirror.bazel.build/github.com/bazelbuild/bazel-toolchains/archive/3.4.0.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
ERROR: An error occurred during the fetch of repository 'bazel_toolchains':
   java.io.IOException: Error downloading [https://github.com/bazelbuild/bazel-toolchains/releases/download/3.4.0/bazel-toolchains-3.4.0.tar.gz, https://mirror.bazel.build/github.com/bazelbuild/bazel-toolchains/archive/3.4.0.tar.gz] to /private/var/tmp/_bazel_runner/3d1a7f52fd47fc9a8db71770aacd13e5/external/bazel_toolchains/bazel-toolchains-3.4.0.tar.gz: GET returned 404 Not Found

@zuercher zuercher merged commit 41c9eb6 into envoyproxy:master Jul 27, 2020
KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request Jul 30, 2020
@KBaichoo
zookeeper: note available latency stats in docs (envoyproxy#12261)
362d686 
This was missed in envoyproxy#7825.

Risk Level: low
Docs Change: docs only
Release Notes: n/a
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
zookeeper: note available latency stats in docs (envoyproxy#12261)
cecccaf 
This was missed in envoyproxy#7825.

Risk Level: low
Docs Change: docs only
Release Notes: n/a
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
zookeeper: note available latency stats in docs (envoyproxy#12261)
73d9ff9 
This was missed in envoyproxy#7825.

Risk Level: low
Docs Change: docs only
Release Notes: n/a
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuercher zuercher zuercher approved these changes

Assignees

@zuercher zuercher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgs1 @zuercher